running quick_suite on ursa#1039
Conversation
|
I've run some tests, things look good. Some suggestions In env.ursa_intel, ICE_MACHINE_MACHINFO looks incorrect, I think it should be ICE_MACHINE_ENVINFO looks incorrect, I think it should be ICE_MACHINE_TPNODE should be 192 ICE_MACHINE_INPUTDATA can be set to In Macros.ursa_intel, I suggest you change the header comment from "hera" to "ursa". It looks like hpcx-mpi is recommended over intel-oneapi-intel. Have you considered using that as the default? We could also consider setting up another ursa env with hpcx-mpi at some point. |
| ##SBATCH --mail-user=xxx@noaa.gov | ||
| EOFB | ||
|
|
||
| else if (${ICE_MACHINE} =~ wcoss2*) then |
There was a problem hiding this comment.
You're also adding wcoss2---Aren't other changes also required in order to run on wcoss2?
There was a problem hiding this comment.
I consider this a pre-adaptation for the WCOSS2, which, yes, requires the env and macros files. This aspect works as is (being uninvoked, but even when it is (development in parallel) it works ok. issues with env and or macros on wcoss2).
| @@ -0,0 +1,59 @@ | |||
| #============================================================================== | |||
| # Makefile macros for NOAA hera, intel compiler | |||
There was a problem hiding this comment.
I agree w/ the other reviewer, that the header should reflect the platform.
|
I've made the noted changes. Regarding hpcx-mpi , I think that's more an item to be tested and implemented on its own. Given other things I'm encountering, I'm leery of changes to compiler family. |
|
@rgrumbine, is this ready to merge as far as you're concerned. I assume gaea and wcoss will be done separately? |
|
@apcraig yes, and yes. Thanks |
|
@DeniseWorthen, feel free to have another quick look. I think our initial comments have been addressed. If I don't see anything new, I'll merge this afternoon. Thanks! |
Add Ursa port, NOAA machine, intel. Add some initial code for WCOSS, another NOAA machine. That port will be completed with a separate PR. Remove support for Discover, env and Macros files could still be removed.
3 participants
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Run environment for NOAA machine ursa
Robert.Grumbine
quick_suite:
16 measured results of 16 total results
16 of 16 tests PASSED
0 of 16 tests PENDING
0 of 16 tests MISSING data
0 of 16 tests FAILED